Skip to content

feat(RingTheory/RootsOfUnity): generalize Ideal.rootsOfUnityMapQuot to commutative rings - #44588

Open
xroblot wants to merge 7 commits into
leanprover-community:masterfrom
xroblot:rootsofunity-mapquot-general
Open

xroblot wants to merge 7 commits into
leanprover-community:masterfrom
xroblot:rootsofunity-mapquot-general

Conversation

@xroblot

@xroblot xroblot commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

The morphism from the roots of unity of order n to the units of a quotient ring is currently stated for the ring of integers of a number field, although nothing about it needs more than a commutative ring. It is moved to a new file and stated in that generality.

It is injective as soon as n does not lie in the ideal, for any domain.

🤖 This PR was extracted from the SKW project by Claude.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

PR summary af974e9c59

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.NumberField.Cyclotomic.Galois Mathlib.NumberTheory.NumberField.Ideal.Basic 1
Mathlib.RingTheory.RootsOfUnity.Quotient (new file) 2017

Declarations diff (regex)

+ IsPrimitiveRoot.not_coprime_absNorm_of_mk_eq_one
+ rootsOfUnityMapQuot
+ rootsOfUnityMapQuot_apply
+ rootsOfUnityMapQuot_coe_apply
+ rootsOfUnityMapQuot_inj
+ rootsOfUnityMapQuot_injective
+ rootsOfUnityMapQuot_injective_of_notMem
- Ideal.rootsOfUnityMapQuot
- Ideal.rootsOfUnityMapQuot_apply
- Ideal.rootsOfUnityMapQuot_inj
- Ideal.rootsOfUnityMapQuot_injective

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit af974e9).

  • +4 new declarations
  • −0 removed declarations
+Ideal.rootsOfUnityMapQuot_coe_apply
+Ideal.rootsOfUnityMapQuot_injective_of_notMem
+Ideal.torsionMapQuot.congr_simp
+IsPrimitiveRoot.not_coprime_absNorm_of_mk_eq_one

No changes to strong technical debt.
No changes to weak technical debt.

Current commit af974e9c59
Reference commit c47f9ad906

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@xroblot xroblot added the WIP Work in progress label Oct 7, 2026
@xroblot xroblot added t-ring-theory Ring theory and removed WIP Work in progress labels Oct 29, 2026
@tb65536 tb65536 added the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Nov 13, 2026
@xroblot xroblot removed the awaiting-author Reply -awaiting-author to remove the label on your PR once you have addressed all comments. label Nov 14, 2026
xroblot added a commit to xroblot/mathlib4 that referenced this pull request Nov 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants